-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: harden TestNetwork and TestNmt even more #508
Tests: harden TestNetwork and TestNmt even more #508
Conversation
Follow-up for shortcomings in #505. |
@acolomb, some rationale for the changes:
I think this should be fine. I'll mark it as ready for review tomorrow morning CET ☕ Footnotes
|
3dacf57
to
bd71065
Compare
- take into account that payloads with DATA1 may be in flight when we update the task - test task.stop() - use more lenient timeout - use threading.Condition for improved readability - wait for periodicity to be established before validation; some platforms are a little bit flaky
bd71065
to
15e5ad2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 68.86% 68.86%
=======================================
Files 26 26
Lines 3112 3112
Branches 526 526
=======================================
Hits 2143 2143
Misses 831 831
Partials 138 138 |
After this PR has landed, I'll follow-up with a small PR to expand the CI matrix so we can run the test suite on macOS and Windows, as well as on Linux. That should prevent failures like #501. |
Do we know what account @christiansandberg have? Are we on a free tier or something paid for? And are we well away from any spending limits on actions? -- Adding new CI matrixes is great, but it triples build minutes, so I think maybe we should give the owner a chance to ok this. |
Ordinary user accounts with public repos are given a pretty large batch of CI minutes per month for free. Anyway, let's discuss this in the following-up PR; it's not related to this change. |
make sure we always collect two framesSee commit messages for details.